Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode usr/share/rpm #764

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

cgwalters
Copy link
Member

We don't need this on modern Fedora anymore for example. If we detect the sysimage path, then just use it.

jmarrero
jmarrero previously approved these changes Nov 6, 2024
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters
Copy link
Member Author

Ah right fun fun, we still set _dbpath /usr/share/rpm in rpm-ostree as canonical...

@jmarrero jmarrero self-requested a review November 20, 2024 18:59
@jmarrero jmarrero dismissed their stale review November 20, 2024 19:00

changes needed on rpm-ostree

@cgwalters cgwalters force-pushed the rpmdb-path branch 2 times, most recently from e22d3bb to b246b66 Compare November 21, 2024 14:04
@cgwalters
Copy link
Member Author

OK right so the problem here was actually that rpm-ostree only writes the macro for the rpmdb in postprocessing.

We don't need this on modern Fedora anymore for example.
If we detect the sysimage path, then just use it.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Member Author

OK this one is actually tested more

Copy link
Member

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuijingHei HuijingHei merged commit 250c6a9 into coreos:main Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants